Codestriker: "Topic Text: CVS commit: * If there is an email problem while creating..."

sits@use...

Topic title: CVS commit: * If there is an email problem while creating...

Monday January 16, 2006 02:49:25

Files in topic:
[Jump to] codestriker/CHANGELOG	1.181	{+3,-0}
[Jump to] codestriker/lib/Codestriker/Action/SubmitNewTopic.pm	1.22	{+2,-1}
[Jump to] codestriker/lib/Codestriker/TopicListeners/Email.pm	1.16	{+4,-3}
[Jump to] codestriker/template/en/default/submitnewtopic.html.tmpl	1.5	{+6,-0}

File codestriker/CHANGELOG (Revision 1.181)

[Add File Comment] [Top] [>>]


Line 20 \| Parallel		Line 20 \| Parallel
20	will correctly display in the AJAX'ed window. An example here is if	20	will correctly display in the AJAX'ed window. An example here is if
21	$mailhost is incorrectly configured.	21	$mailhost is incorrectly configured.
22		22
		23	* If there is an email problem while creating a topic, the error
		24	message is now correctly displayed to the end-user.
		25
23	* Fixed problem with Subversion repositories on Win32, where	26	* Fixed problem with Subversion repositories on Win32, where
24	Codestriker was unable to launch the svn program.	27	Codestriker was unable to launch the svn program.
25		28

File codestriker/lib/Codestriker/Action/SubmitNewTopic.pm (Revision 1.22)

[Add File Comment] [<<] [Top] [>>]

     # Tell all of the topic listener classes that a topic has
     # just been created.
-    Codestriker::TopicListeners::Manager::topic_create($topic);
+    $feedback = Codestriker::TopicListeners::Manager::topic_create($topic);
     # Obtain a URL builder object and determine the URL to the topic.
     my $topic_url = $url_builder->view_url_extended($topicid, -1, "", "", "",
     $vars->{'topic_url'} = $topic_url;
     $vars->{'reviewers'} = $reviewers;
     $vars->{'cc'} = (defined $cc) ? $cc : "";
+    $vars->{'feedback'} = $feedback;
     my $template = Codestriker::Http::Template->new("submitnewtopic");
     $template->process($vars);

File codestriker/lib/Codestriker/TopicListeners/Email.pm (Revision 1.16)

[Add File Comment] [<<] [Top] [>>]

         my $cc = "";
         # Send off the email to the revelant parties.
-        $self->_send_topic_email($topic, 0,$change_event_name , 1, $from,
+        return $self->_send_topic_email($topic, 0, $change_event_name , 1,
-                                 $to, $cc, $bcc,$changes);
+                                        $from, $to, $cc, $bcc, $changes);
     }
 }
         $notes;
     # Send the email notification out.
-    $self->doit($new, $topic->{topicid}, $from, $to, $cc, $bcc, $subject, $body);
+    return $self->doit($new, $topic->{topicid}, $from, $to, $cc, $bcc,
+                       $subject, $body);
 }
 # Send an email with the specified data.  Return a non-empty message if the

File codestriker/template/en/default/submitnewtopic.html.tmpl (Revision 1.5)

[Add File Comment] [<<] [Top]

 [% PROCESS header.html.tmpl version = version displaymenu = 1
                             closehead = 1 help="" %]
+[%# Display any "feedback" to the user if necessary. #%]
+[% IF feedback != '' %]
+    <font color="red">[% feedback %]</font>
+    <p>
+[% END %]
 <H2>Topic created</H2>
 Topic title: [% topic_title | html_entity %]<BR>
 Author: [% email | html_entity %]<BR>