| |
| 1 |
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN"> |
| 2 |
<html xmlns="http://www.w3.org/1999/xhtml" lang="en-US" xml:lang="en-US"> |
| 3 |
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> |
| 4 |
<head><title>Codestriker: "Create New Topic"</title> |
| 5 |
<link rel="stylesheet" type="text/css" href="http://9.123.251.126/codestrikerhtml/codestriker.css" /> |
|
<script src="http://9.123.251.126/codestrikerhtml/overlib.js" type="text/javascript"></script> |
| 7 |
<script src="http://9.123.251.126/codestrikerhtml/overlib_centerpopup.js" type="text/javascript"></script> |
| 8 |
<script src="http://9.123.251.126/codestrikerhtml/overlib_draggable.js" type="text/javascript"></script> |
| 9 |
<script src="http://9.123.251.126/codestrikerhtml/xbdhtml.js" type="text/javascript"></script> |
| 10 |
<script src="http://9.123.251.126/codestrikerhtml/codestriker.js" type="text/javascript"></script> |
| 11 |
<script type="text/javascript"> |
| 12 |
var cs_load_anchor = ''; |
| 13 |
var cs_reload = 0; |
| 14 |
var cs_email = 'tanyb@cn.ibm.com'; |
| 15 |
var cs_css = 'http://9.123.251.126/codestrikerhtml/codestriker.css'; |
| 16 |
var cs_xbdhtml_js = 'http://9.123.251.126/codestrikerhtml/xbdhtml.js'; |
| 17 |
var cs_metric_data = new Array(); |
| 18 |
cs_metric_data[0] = new Object(); |
| 19 |
cs_metric_data[0].name = 'Status'; |
| 20 |
cs_metric_data[0].values = new Array(); |
| 21 |
cs_metric_data[0].values[0] = 'Submitted'; |
| 22 |
cs_metric_data[0].values[1] = 'Invalid'; |
| 23 |
cs_metric_data[0].values[2] = 'Completed'; |
| 24 |
cs_metric_data[0].default_value = 'Submitted'; |
| 25 |
if ('function' != typeof window.add_comment_html) { |
| 26 |
alert('Oh oh... can\'t find codestriker.js, please check your web-server config.'); |
| 27 |
} |
| 28 |
</script> |
| 29 |
|
| 30 |
<!-- Source was not sent compressed. --> |
| 31 |
</head> |
| 32 |
<body onLoad="gotoAnchor(cs_load_anchor, cs_reload);"> |
| 33 |
|
| 34 |
|
| 35 |
|
| 36 |
<div id="header"> |
| 37 |
<div class="heading"> |
| 38 |
<a href="http://9.123.251.126/codestriker/codestriker.pl?action=list_topics&sstate=0">Codestriker 1.9.7 - Create New Topic</a> |
| 39 |
</div> |
| 40 |
|
| 41 |
<div class="menu"> |
| 42 |
<a href="http://9.123.251.126/codestriker/codestriker.pl?action=list_topics&sstate=0">List all open topics</a> |
| 43 |
| <a href="http://9.123.251.126/codestriker/codestriker.pl?action=create">Create new topic</a> | <a href="http://9.123.251.126/codestriker/codestriker.pl?action=search">Search</a> | <a href="http://9.123.251.126/codestriker/codestriker.pl?action=login">Log In</a> |
| 44 |
| <a href="http://9.123.251.126/codestrikerhtml/codestriker.html">Manual</a> |
| 45 |
</div> |
| 46 |
</div> |
| 47 |
|
| 48 |
|
| 49 |
|
| 50 |
<P> |
| 51 |
|
| 52 |
|
| 53 |
|
| 54 |
<FORM NAME="createtopicform" METHOD="post" ENCTYPE="multipart/form-data" ACCEPT-CHARSET="UTF-8" action="http://9.123.251.126/codestriker/codestriker.pl" |
| 55 |
> |
| 56 |
<INPUT TYPE="hidden" NAME="action" VALUE="submit_new_topic" /> |
| 57 |
<INPUT TYPE="hidden" NAME="obsoletes" VALUE="" /> |
| 58 |
|
| 59 |
|
| 60 |
Topic title: |
| 61 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 62 |
onmouseout="return nd();" |
| 63 |
onmouseover="return create_window('The topic title should be a concise but \ |
| 64 |
informative summary of the code to be reviewed. The title is used in the \ |
| 65 |
subject of sent emails, and in the topic list screen.');">(?)</a></FONT> |
| 66 |
<BR/> |
| 67 |
<INPUT TYPE="text" NAME="topic_title" VALUE="" SIZE=70 MAXLENGTH=70 /> |
| 68 |
<P> |
| 69 |
|
| 70 |
|
| 71 |
Topic description: |
| 72 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 73 |
onmouseout="return nd();" |
| 74 |
onmouseover="return create_window('\ |
| 75 |
The topic description should contain enough information \ |
| 76 |
for a reviewer to understand broadly what the code change \ |
| 77 |
achieves. This information is sent with the new topic \ |
| 78 |
notification email to all reviewers.')">(?)</a></FONT> |
| 79 |
<BR/> |
| 80 |
<TEXTAREA NAME="topic_description" ROWS=12 COLS=70 WRAP="hard"></TEXTAREA> |
| 81 |
<P> |
| 82 |
|
| 83 |
<TABLE> |
| 84 |
|
| 85 |
<TR> |
| 86 |
<TD>Topic text upload: |
| 87 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 88 |
onmouseout="return nd();" |
| 89 |
onmouseover="return create_window('\ |
| 90 |
The uploaded file contains the actual text of the review. \ |
| 91 |
Typically, the text is the output of a command such as: \ |
| 92 |
<p> \ |
| 93 |
cvs diff -uN > output.txt \ |
| 94 |
<p> or <p> \ |
| 95 |
svn diff -uN > output.txt \ |
| 96 |
<p> or <p> \ |
| 97 |
diff -urN ../old-version/ . > output.txt \ |
| 98 |
<p> \ |
| 99 |
Non-unidiff files, or ordinary text files can be uploaded, \ |
| 100 |
but will be treated simply as \'new files\'. \ |
| 101 |
<p> \ |
| 102 |
This should be left blank if you are reviewing files \ |
| 103 |
directly from a repository.')">(?)</a></FONT> |
| 104 |
</TD> |
| 105 |
<TD COLSPAN="3"><INPUT TYPE="file" NAME="topic_file" VALUE="" SIZE=40 MAXLENGTH=200 /></TD> |
| 106 |
</TR> |
| 107 |
|
| 108 |
|
| 109 |
<TR> |
| 110 |
<TD> |
| 111 |
Start tag: |
| 112 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 113 |
onmouseout="return nd();" |
| 114 |
onmouseover="return create_window('\ |
| 115 |
Rather than uploading the topic text, if the repository \ |
| 116 |
supports it, the text can be fetched by querying the \ |
| 117 |
repository, given start and/or end tags, and a module name. \ |
| 118 |
The start tag, end tag, and module fields are ignored if text \ |
| 119 |
is uploaded.<p> \ |
| 120 |
If only one tag value is specified, the full contents of all \ |
| 121 |
files in the specified module corresponding to the entered tag \ |
| 122 |
will be downloaded.')">(?)</a></FONT> |
| 123 |
</TD> |
| 124 |
<TD> |
| 125 |
<INPUT TYPE="text" NAME="start_tag" VALUE="" SIZE=20 MAXLENGTH=150 /> |
| 126 |
</TD> |
| 127 |
<TD>End tag: <FONT SIZE="-2"><a href="javascript:void(0);" |
| 128 |
onmouseout="return nd();" |
| 129 |
onmouseover="return create_window('\ |
| 130 |
Rather than uploading the topic text, if the repository \ |
| 131 |
supports it, the text can be fetched by querying the \ |
| 132 |
repository, given start and/or end tags, and a module name. \ |
| 133 |
The start tag, end tag, and module fields are ignored if text \ |
| 134 |
is uploaded. <p> \ |
| 135 |
If only one tag value is specified, the full contents of all \ |
| 136 |
files in the specified module corresponding to the entered tag \ |
| 137 |
will be downloaded.')">(?)</A></FONT></TD> |
| 138 |
<TD> |
| 139 |
<INPUT TYPE="text" NAME="end_tag" VALUE="" SIZE=20 MAXLENGTH=150 /> |
| 140 |
</TD> |
| 141 |
</TR> |
| 142 |
<TR> |
| 143 |
<TD> </TD><TD> </TD> |
| 144 |
<TD> |
| 145 |
Module: |
| 146 |
<FONT SIZE="-2"><A HREF="javascript:void(0);" |
| 147 |
onmouseout="return nd();" |
| 148 |
onmouseover="return create_window('\ |
| 149 |
This is the path to the file or module relative to the repository \ |
| 150 |
root that should be inspected. It is ignored if text is uploaded.')">(?)</a></FONT> |
| 151 |
</TD> |
| 152 |
<TD> |
| 153 |
<INPUT TYPE="text" NAME="module" VALUE="" SIZE=20 MAXLENGTH=150 /> |
| 154 |
</TD> |
| 155 |
</TR> |
| 156 |
|
| 157 |
<TR> |
| 158 |
<TD> </TD><TD> </TD> |
| 159 |
|
| 160 |
<TD>Default to HEAD: |
| 161 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 162 |
onmouseout="return nd();" |
| 163 |
onmouseover="return create_window('\ |
| 164 |
Fall back to HEAD revision if a file does not exist on either tag. \ |
| 165 |
This will allow diffs between a branch and the HEAD revision, without \ |
| 166 |
showing files not on the branch as deleted. \ |
| 167 |
This option affects only CVS topics currently.')">(?)</A></FONT> |
| 168 |
</TD> |
| 169 |
<TD COLSPAN="3"><INPUT TYPE="checkbox" NAME="default_to_head" /></TD> |
| 170 |
</TR> |
| 171 |
|
| 172 |
|
| 173 |
|
| 174 |
|
| 175 |
|
| 176 |
|
| 177 |
<TR> |
| 178 |
<TD>Project: |
| 179 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 180 |
onmouseout="return nd();" |
| 181 |
onmouseover="return create_window('\ |
| 182 |
Topics are associated with a specific project, which can be \ |
| 183 |
used as filtering criteria in the search screen.')">(?)</a></FONT> |
| 184 |
</TD> |
| 185 |
<TD COLSPAN="3"><SELECT NAME="projectid"> |
| 186 |
<OPTION VALUE="1">Default project</OPTION> |
| 187 |
<OPTION VALUE="3">mmprovider</OPTION> |
| 188 |
<OPTION VALUE="2">test</OPTION> |
| 189 |
</SELECT> |
| 190 |
</TD> |
| 191 |
</TR> |
| 192 |
|
| 193 |
|
| 194 |
|
| 195 |
<TR> |
| 196 |
<TD>Bug IDs: |
| 197 |
<FONT SIZE="-2"><a href="javascript:void(0)" |
| 198 |
onmouseout="return nd();" |
| 199 |
onmouseover="return create_window('\ |
| 200 |
Indicates what bug identifiers are addressed by this code change. \ |
| 201 |
These are space or comma separated identifiers, such as: \ |
| 202 |
<p> \ |
| 203 |
1634 \ |
| 204 |
<p> \ |
| 205 |
or \ |
| 206 |
<p> \ |
| 207 |
1534, 4625, 1243 \ |
| 208 |
<p> \ |
| 209 |
The appropriate links to the bug-tracking system will be made \ |
| 210 |
when the topic is viewed, for the reviewer\'s reference. \ |
| 211 |
<p> \ |
| 212 |
In addition, if integrating with Bugzilla, when the topic state \ |
| 213 |
is changed, a comment will be inserted automatically to the \ |
| 214 |
associated bugs for cross referencing. When a bug is viewed, \ |
| 215 |
it can be easily determined what code fixes have been applied \ |
| 216 |
to it.')">(?)</a></FONT> |
| 217 |
</TD> |
| 218 |
<TD COLSPAN="3"><INPUT TYPE="text" NAME="bug_ids" VALUE="" SIZE=30 MAXLENGTH=50 /></TD> |
| 219 |
</TR> |
| 220 |
|
| 221 |
|
| 222 |
<TR> |
| 223 |
<TD>Your email address: |
| 224 |
<FONT SIZE="-2"><A HREF="javascript:void(0);" |
| 225 |
onmouseout="return nd();" |
| 226 |
onmouseover="return create_window('\ |
| 227 |
This is your email address. All comments made against a topic \ |
| 228 |
will be sent to this address. The new topic notification email \ |
| 229 |
will also be sent to this address.')">(?)</a></FONT> |
| 230 |
</TD> |
| 231 |
<TD COLSPAN="3"><INPUT TYPE="text" NAME="email" VALUE="tanyb@cn.ibm.com" SIZE=50 MAXLENGTH=80 /></TD> |
| 232 |
</TR> |
| 233 |
|
| 234 |
|
| 235 |
<TR> |
| 236 |
<TD>Reviewers: |
| 237 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 238 |
onmouseout="return nd();" |
| 239 |
onmouseover="return create_window('\ |
| 240 |
This is a comma separated list of email addresses, which are the \ |
| 241 |
people who need to review this code. When the topic is created, \ |
| 242 |
the new topic notification email will be sent to these addresses.')">(?)</a></FONT> |
| 243 |
</TD> |
| 244 |
<TD COLSPAN="3"><INPUT TYPE="text" NAME="reviewers" VALUE="" SIZE=50 MAXLENGTH=1024 /></TD> |
| 245 |
</TR> |
| 246 |
|
| 247 |
|
| 248 |
<TR> |
| 249 |
<TD>Cc: |
| 250 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 251 |
onmouseout="return nd();" |
| 252 |
onmouseover="return create_window('\ |
| 253 |
This is a comma separated list of email addresses, which are \ |
| 254 |
not intended to be reviewers, but typically a mailing list \ |
| 255 |
to notify a number of people about the creation of a new topic.')">(?)</a></FONT> |
| 256 |
</TD> |
| 257 |
<TD COLSPAN="3"><INPUT TYPE="text" NAME="cc" VALUE="" SIZE=50 MAXLENGTH=1024 /></TD> |
| 258 |
</TR> |
| 259 |
|
| 260 |
<tr> |
| 261 |
<td>State: |
| 262 |
<FONT SIZE="-2"><a href="javascript:void(0);" |
| 263 |
onmouseover="return create_window('When a topic is created, it is by default in state \'open\'.\ |
| 264 |
Once a topic has been reviewed, and the code has been committed, \ |
| 265 |
the state should be updated to \'committed\'. If the code \ |
| 266 |
in this review is not to be committed, perhaps because a \ |
| 267 |
new review will superceed this one, or because it was rejected, \ |
| 268 |
the state should be changed to \'closed\'. \ |
| 269 |
\ |
| 270 |
If a topic is linked to Bugzilla bugs, each time the topic \ |
| 271 |
state is changed, an appropriate comment will be appended to \ |
| 272 |
all associated bugs, as a form of tracking. \ |
| 273 |
\ |
| 274 |
The topic states are also useful as a form of filtering, when \ |
| 275 |
retrieving lists of topics from the search page. \ |
| 276 |
\ |
| 277 |
This topic can be superceeded by a new topic, by selecting the \ |
| 278 |
state \'obsoleted\'.');" |
| 279 |
onmouseout="return nd();">(?)</A></FONT> |
| 280 |
</td> |
| 281 |
<td> |
| 282 |
|
| 283 |
<select name="topic_state"> |
| 284 |
<option selected value="Open">Open</option> |
| 285 |
<option value="Closed">Closed</option> |
| 286 |
<option value="Committed">Committed</option> |
| 287 |
</select> |
| 288 |
</td> |
| 289 |
</tr> |
| 290 |
</TABLE> |
| 291 |
|
| 292 |
<P> |
| 293 |
<INPUT TYPE="submit" NAME=".submit" VALUE="Create Topic" /> |
| 294 |
|
| 295 |
</FORM> |
| 296 |
|
| 297 |
|
| 298 |
</BODY> |
| 299 |
</HTML> |
| |