3.6. Viewing Comments

From the "View Topic" page (see Section 3.5.1), the "Topic Comments" tab can be clicked to view the comments associated with a topic. This can be clicked at any stage to see what comments have been submitted against a review. It is often necessary for the author once a review has been completed, to work their way through the comments from the browser, although they can do this with their email client as well (assuming $allow_comment_email is true in codestriker.conf), since each comment will generate an email message. An example screenshot of the "Topic Comments" page can be seen in Figure 3-10.

Figure 3-10. Topic Comments Screenshot

A separate heading is shown in the display, for each line in the review which has at least one comment made against it. For each line, all of the comments made are shown, including the author and date information. Each comment block has a state associated with it, which is primarily for the author's benefit to change. The following states are defined:

Submitted

This is the initial state that a comment block will have.

Invalid

This can be set to indicate that the comments made in this block are actually not valid.

Completed

This is typically set by the author, as a record, to indicate that the comments in this block have been subsequently addressed in their code.

For each comment block, there are three links to other Codestriker screens. The first link will bring up a "View File" page (see Section 3.5.3) centered on the line number of the comment, "Parallel" will do the same, by using the parallel view, and the "Add comment" link will bring up the "Add Comment" page (see Section 3.5.2) for that line number.

In this particular example, there are two comment blocks, for file codestriker/codestriker.pl, on lines 27 and 60.

At the top of this page are a number of filtering options, which control what comments are displayed. Comments can be filtered by the author of the comment and/or by comment block state. In addition, for each comment block, it is also possible to display the context of the topic text the comment block is made against (as is done for the "Add Comment" page, see Section 3.5.2). These controls provide the capability for generating code review reports, which can then be used at code inspection meetings.